05-Specifications / 05.09.API-Fix-Duplicate-Tests.spec

05.09.API Fix Duplicate Tests.spec

05.09. API Fix Duplicate Tests.spec

Overview

Analysis of the bnc-cpt-api test suite reveals several areas of duplication, particularly in the payment service tests. Many tests are repeated across multiple files at both the service layer and the endpoint layer without clear separation of concerns.

Pinpointed Duplications

1. Payment Service Logic

• Duplicate Files: tests/test_payment.py and tests/test_payment_service.py.
• Overlapping Tests:
  • _validate_payment_id: Tested in both files.
  • _mark_session_paid_if_linked: Tested in both files.
  • verify_payment: Tested in both files.
  • _ensure_receipt_pdf: Tested in both files.
• Recommendation: Consolidate all service-layer unit tests into tests/test_payment_service.py. Remove the TestPaymentServiceUnit class and related methods from tests/test_payment.py.

2. Authentication Logic

• Duplicate Files: tests/test_auth.py and tests/test_auth_service.py.
• Overlapping Tests: Both files test the authentication of the admin user. test_auth.py does it via HTTP, while test_auth_service.py does it via service calls.
• Recommendation: Keep endpoint tests in test_auth.py focused on HTTP status codes and response structures. Ensure test_auth_service.py handles all edge cases for the logic itself.

3. Tesla Provider Logic

• Duplicate Files: test_tesla.py, test_tesla_router.py, test_tesla_fleet_service.py, test_tesla_fleet_helpers.py, test_tesla_normalization.py, test_tesla_provider_auth.py, test_tesla_provider_client.py.
• Overlapping Tests:
  • OAuth Initiation: Tested in test_tesla.py (HTTP + Logic), test_tesla_router.py (HTTP), and test_tesla_fleet_service.py (Logic).
  • Session Management: get_vehicles, select_vehicles, and mark_session_paid are tested redundantly across test_tesla.py, test_tesla_router.py, and test_tesla_fleet_service.py.
  • Helpers: Methods like _car_type_to_model and _vin_to_year are tested in both test_tesla.py and test_tesla_fleet_helpers.py.
  • Normalization: Logic for mapping Tesla API responses is spread across test_tesla.py and test_tesla_normalization.py.
• Recommendation:
  • Phase Out test_tesla.py: This file has become a "catch-all" that duplicates specialized files. Its contents should be moved to the specialized files and then deleted.
  • Consolidate Helpers: All static utility functions should be tested exclusively in test_tesla_fleet_helpers.py.
  • Strict Layering: Ensure test_tesla_router.py only tests HTTP-related concerns (status codes, JSON serialization) and mocks the service layer entirely. All business logic and Redis state transitions should live in test_tesla_fleet_service.py.

Proposed Action Plan

1. Surgical Merge: Move TestPaymentServiceUnit from test_payment.py to test_payment_service.py if anything is missing there, then delete it from test_payment.py.
2. Refactor Auth Tests: Remove logic-heavy tests from test_auth.py and ensure they are covered in test_auth_service.py.
3. Tesla Test Consolidation: Group Tesla-related tests by responsibility:
   • test_tesla_api.py: Router/Endpoint tests.
   • test_tesla_service.py: Business logic and orchestration.
   • test_tesla_provider.py: Low-level provider/client tests (Tesla Fleet API specifics).
4. Shared Fixtures: Move common mocks (like mock_redis, mock_stripe, mock_tesla) to a central conftest.py to reduce boilerplate duplication in before blocks.