05-Specifications / 05.10.WUI-Fix-Duplicate-Tests.spec

05.10.WUI Fix Duplicate Tests.spec

05.10. WUI Fix Duplicate Tests.spec

Overview

Analysis of the bnc-cpt-wui (The Bot) Puppeteer test suite reveals significant duplication of browser setup logic and redundant testing of UI components across different functional specifications.

Pinpointed Duplications

1. Landing Page Redundancy

• Duplicate Specs: test-101.landing-page.spec.js and test-105.user-journey.spec.js.
• Overlapping Tests:
  • Page loads and title contains 'Car Pulse Tracker': Repeated multiple times.
  • Clicking Tesla brand selects it: Overlapped logic in both specs.
• Recommendation: Use test-101 as the source of truth for all static landing page elements. Ensure test-105 only focuses on the transition between steps.

2. Language Switcher Redundancy

• Duplicate Specs: test-101.landing-page.spec.js and test-103.language-switcher.spec.js.
• Overlapping Tests: Language switcher toggles UI text is tested in test-101 but more comprehensively in test-103.
• Recommendation: Remove the language switcher test from test-101.

3. Step Navigation Overlap

• Duplicate Specs: test-105.user-journey.spec.js and test-106.back-navigation.spec.js.
• Observation: Both specs repeat the sequence Landing → Brand → OAuth Mock → Package Step.
• Recommendation: Move complex navigation sequences to helper functions in test.utils.js (like the existing utils.navigateToPackageStep) to ensure consistency and reduce code duplication.

4. Boilerplate Setup Duplication

• Global Observation: Almost every test file repeats the beforeEach block for browser launch and navigation.
• Recommendation: Refactor common setup logic into a shared helper or a root-level beforeEach if possible with Mocha. Use a more robust test.config.js to manage session state without full browser restarts between tests.

Proposed Action Plan

1. Refactor test.utils.js: Centralize all navigation helpers (e.g., utils.selectBrand('tesla'), utils.completePackageStep('pro', 'stripe')).
2. Surgical Cleanup: Remove redundant tests from test-101 and test-105.
3. Merge Tesla Flows: Consolidate test-303.tesla-full-blind-flow.spec.js and test-304.tesla-semi-auto-flow.spec.js into a single parameterized test file to minimize duplication of common steps.
4. Screenshot Management: Standardize screenshot names on failure to prevent naming collisions and duplicate captures.